aindreas/traintracker
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix logs to reflect that empty snapshot is likely not an error

Browse Source 
Additionally replace incorrect 404 message
This commit is contained in:
Aindréas Ó hAodha
2023-08-15 12:15:31 +01:00
parent 63d2508423
commit 3be37dad99
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
functions/index.js
View File

@ -20,8 +20,8 @@ exports.getStationData = functions.https.onRequest((request, response) => {
// fetch the "stations" collection // fetch the "stations" collection
admin.firestore().collection('stations').get().then((snapshot) => { admin.firestore().collection('stations').get().then((snapshot) => {
if (snapshot.empty) { if (snapshot.empty) {
functions.logger.log("Error fetching station data from Firestore") functions.logger.log("Empty snapshot received when fetching station data from Firestore")
response.status(404).send({data: "Error fetching station data from Firestore"}) response.status(404).send({data: "Empty snapshot received when fetching station data from Firestore"})
return; return;
} }
// iterate through each of the collection's documents // iterate through each of the collection's documents
@ -185,8 +185,8 @@ exports.getLiveTrainData = functions.https.onRequest((request, response) => {
// fetch the "liveTrainData" collection // fetch the "liveTrainData" collection
admin.firestore().collection('liveTrainData').get().then((snapshot) => { admin.firestore().collection('liveTrainData').get().then((snapshot) => {
if (snapshot.empty) { if (snapshot.empty) {
functions.logger.log("Error fetching live train data from Firestore") functions.logger.log("Empty snapshot received when fetching live train data from Firestore")
response.status(404).send({data: "Successfully fetched live train data from Firestore"}); response.status(404).send({data: "Empty snapshot received when fetching live train data from Firestore"});
return; return;
} }
// iterate through each of the collection's documents // iterate through each of the collection's documents
@ -489,4 +489,4 @@ exports.deletePreferences = functions.https.onCall((data, context) => {
functions.logger.log("Successfully deleted user preferences from Firestore") functions.logger.log("Successfully deleted user preferences from Firestore")
return "Successfully deleted user preferences from Firestore" return "Successfully deleted user preferences from Firestore"
}) })
}) })